布尔比较当它应该为true时返回false
问题描述:
这是作业,抬起头来。我要写一个卡牌类,甲板类,必须有Equals(甲板甲板),每8个洗牌应该完全匹配原始甲板,打印20次迭代。我有我的洗牌工作 - 第8次和第16次洗牌是一样的原始甲板,但等号班不断返回假。我错过了一些东西,并一直在仔细研究这一点 - 任何人都可以指导我解决我的错误?提前致谢!布尔比较当它应该为true时返回false
namespace lab2part3
{
public class DeckOfCards : Card
{
const int CARDS = 52;
private Card[] cards;
public void Deck()
{
cards = new Card[CARDS];
for (int suitVal = 0; suitVal < 4; suitVal++)
{
for (int rankVal = 1; rankVal < 14; rankVal++)
{
cards[suitVal * 13 + rankVal - 1] = new Card((Suit)suitVal, (Rank)rankVal);
}
}
}
public Card GetCard(int cardNum)
{
if (cardNum >= 0 & cardNum <= 51)
return cards[cardNum];
else
throw (new System.ArgumentOutOfRangeException("cardNum", cardNum, "Value must be between 0 and 51."));
}
public void Shuffle()
{
Card[] newDeck = new Card[CARDS];
bool[] assigned = new bool[CARDS];
Random sourceGen = new Random();
for (int i = 0; i < 52; i++)
{
int destCard = 0;
bool foundCard = false;
while (foundCard == false)
{
destCard = sourceGen.Next(CARDS);
if (assigned[destCard] == false)
foundCard = true;
}
assigned[destCard] = true;
newDeck[destCard] = cards[i];
}
newDeck.CopyTo(cards, 0);
}
public void Faro()
{
Card[] firstDeck = new Card[26];
Card[] secondDeck = new Card[26];
Card[] finalDeck = new Card[CARDS];
Array.Copy(cards, 0, firstDeck, 0, 26);
Array.Copy(cards, 26, secondDeck, 0, 26);
for (int i = 0, j = 0; i < CARDS; i += 2, j++)
{
cards[i] = firstDeck[j];
cards[i + 1] = secondDeck[j];
}
}
public bool Equals(DeckOfCards other)
{
for (int i = 0; i < CARDS; i++)
{
if (cards[i] != other[i])
{
return false;
}
}
return true;
}
public Card this[int i]
{
get { return cards[i]; }
}
}
}
-
namespace lab2part3
{
public class Card
{
public enum Suit { H, C, D, S }
public enum Rank { _A = 1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _J, _Q, _K }
public Suit suit { get; set; }
public Rank rank { get; set; }
public Card(Suit newSuit, Rank newRank)
{
suit = newSuit;
rank = newRank;
}
public Card() { }
public override string ToString()
{
StringBuilder s = new StringBuilder(rank.ToString());
s.Remove(0, 1);
return (s + "" + suit);
}
public bool Equals(Card other)
{
return rank == other.rank && suit == other.suit;
}
}
}
-
namespace lab2part3
{
public class CardTester
{
public static void Main()
{
DeckOfCards MyDeck = new DeckOfCards();
DeckOfCards CopyDeck = new DeckOfCards();
Card tempCard = new DeckOfCards();
MyDeck.Deck();
CopyDeck.Deck();
// initial deck setup
for (int i = 0; i < 52; i++)
{
tempCard = MyDeck.GetCard(i);
Console.Write(tempCard.ToString());
if (i != 51)
Console.Write(", ");
else
Console.WriteLine();
if (i == 12 || i == 25 || i == 38)
Console.WriteLine();
}
// 20 looped shuffles
for (int j = 0; j < 20; j++)
{
MyDeck.Faro();
Console.WriteLine("\nShuffle #" + (j + 1) + ":\n");
for (int i = 0; i < 52; i++)
{
tempCard = MyDeck.GetCard(i);
Console.Write(tempCard.ToString());
if (i != 51)
Console.Write(", ");
else
Console.WriteLine();
if (i == 12 || i == 25 || i == 38)
Console.WriteLine();
}
// compare
Console.WriteLine("does this deck equal the original deck? {0}", CopyDeck.Equals(MyDeck));
// print original deck
for (int i = 0; i < 52; i++)
{
tempCard = CopyDeck.GetCard(i);
Console.Write(tempCard.ToString());
if (i != 51)
Console.Write(", ");
else
Console.WriteLine();
if (i == 12 || i == 25 || i == 38)
Console.WriteLine();
}
}
Console.ReadKey();
}
}
}
答
你cards[i] != other[i]
检查使用!=
操作引用类型时使用(除非你明确地超负荷吧)引用相等。你已经实现了一个Card.Equals
方法,用它来代替:
for (int i = 0; i < CARDS; i++)
{
if (!cards[i].Equals(other[i]))
{
return false;
}
}
而是定义新Equals
方法,你应该重写object.Equals
方法。 你可以阅读this和this article以获得更多关于C#中的平等的信息。
答
好吧,首先,你的洗牌方法是超在有效的,所以我必须解决这个问题:
public void Shuffle()
{
Random sourceGen = new Random();
for (int i = 0; i < 52; i++)
{
Card temp = cards[i];
int pos = sourceGen.Next(CARDS);
cards[i] = cards[pos];
cards[pos] = temp;
}
}
至于你的问题,你需要两个对象的数据之间的比较。
for (int i = 0; i < CARDS; i++)
{
if (!cards[i].Equals(other[i]))
{
return false;
}
}
第三,DeckOfCards
不应Card
继承,他们没有任何关系
所述的方法,public void Deck
应该DeckOfCards
答
变化的构造......
public bool Equals(DeckOfCards other)
{
for (int i = 0; i < CARDS; i++)
{
if (cards[i] != other[i])
{
return false;
}
}
return true;
}
对此改为...
public bool Equals(DeckOfCards other)
{
for (int i = 0; i < CARDS; i++)
{
if (!cards[i].Equals(other[i]))
{
return false;
}
}
return true;
}
晚自习适当的方式来覆盖的Object.Equals,以及处理运算符重载的!=等
+0
谢谢 - 这解决了我的整个问题! – JRags
为什么'DeckOfCards'从'Card'继承?一副扑克牌不是一种特殊类型的卡片 –
我已经对代码进行了重构,以便您可以看到代码是如何写入的 - 也许可以从中学习。它按照描述正确工作。你可以在这里找到它(https://dotnetfiddle.net/uUmStC)。 – Enigmativity